phpcbf: fix all at once #1450
Merged
phpcbf: fix all at once #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. DId you have any issues similar to what I described, with nested arrays messing phpcbf up? |
|
hmmm - judging from the travis run, it looks like phpcbf created a few problems :-/ |
|
Yes. I thought that was a type hint check. |
|
Some errors could not be fixed. First I removed the ThirdParty from system (I do not found a way to ignore it) and run: The put the ThirdParty in the place. |
|
|
I think that we should disable phpcbf until either the coding-standard gets upgraded, or the phpcbf issues (if the fault lies there) get addressed :( This is looking ridiculous! |
natanfelles
force-pushed
the
reformat
branch
from
14056bc to
015d7b0
Compare
natanfelles
force-pushed
the
reformat
branch
from
35195f7 to
7587bfa
Compare
|
Good job! maybe we don't need to disable phpcbf?? |
|
I do not know. I like the pre-commit hook. When I use SublimeText, I reformat the code using this package https://github.com/Ennosuke/PHP-Codebeautifier with this settings: {
"path": "~/.config/composer/vendor/bin/phpcbf",
//"level": "PSR12",
"level": "CodeIgniter4",
"patch": "true",
"encoding": "UTF-8",
"on_save": false,
"on_load": false,
"syntaxes": [
"Packages/PHP/PHP.tmLanguage",
"Packages/PHP/PHP.sublime-syntax"
],
"suffix": "",
"sniffs": [],
"tab_width": ""
}With PhpStorm, I created rules according with the CodeIgnite4 Standard. Netbeans is buggy here. |
|
Sorry - some of the changes I had in progress broke some of the work you were doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids the amount of changes in the next revisions.
Checklist: