Bug pars xml

[demortx]

CodeIgniter4/system/Format/XMLFormatter.php

Line 94 in f7dfb40

if (! is_numeric($key))

1. arrayToXML(['BBB096630BD' => 'data...'], ...) - Its ok
2. arrayToXML(['096630FR' => 'data...'], ...) - No ok

The problem with the second example is that it starts with a digit, and passes the check for! is_numeric, and when parsing back into an object, this xml gives an error.

The solution I think is to add a check for the first character not a digit and if a digit then add 'item'

[paulbalandan]

Can you try the latest develop version? The code you're referencing is quite outdated.

[paulbalandan]

On second look, isn't this the same to your own #3092 ?

OK. You're right. 😁

[demortx]

A new bug got out if by accident xml text comes across in the key, then the parser does not work correctly

return preg_replace('/^(xml).*/iu', 'item$0', $key); // XML is a reserved starting word

Exemple:
arr[
'XMLtest' => [ ... ]
]

CodeIgniter4/system/Format/XMLFormatter.php

Line 103 in fc9e219

return preg_replace('/^(xml).*/iu', 'item$0', $key); // XML is a reserved starting word

[paulbalandan]

A new bug got out if by accident xml text comes across in the key, then the parser does not work correctly

return preg_replace('/^(xml).*/iu', 'item$0', $key); // XML is a reserved starting word

Exemple:
arr[
'XMLtest' => [ ... ]
]

CodeIgniter4/system/Format/XMLFormatter.php

Line 103 in fc9e219

return preg_replace('/^(xml).*/iu', 'item$0', $key); // XML is a reserved starting word

A user provided key cannot start with XML, regardless of case, because it is a reserved word for the XML specification. In this case, item will be prepended to the key so that it will not cause an error.

Your example is covered by the test case. Please look at the data provider.