Issues with redirects - had to use exit to make it work and blank page

[daljit3]

---

name: Bug report
about: Help us improve the framework by reporting bugs!

---

Describe the bug
There are two issues with the redirect() method.

1. I am not able to use return redirect()->to('/'); so I have to follow it up with an exit to make it work. e.g.

public function hello() {
//this won't work;
return redirect()->to('/');
//this works
redirect()->to('/');
exit;
}

2. The other issue is none of the redirects are working now since approximately after yesterday (17 nov 2018) evening. To make sure, I haven't accidently broken it, I just downloaded a new copy of CI4-develop and after setup I could see welcome message to confirm everything working fine. Then I made these modifications below to the Home controller. If I try mylocalsite/home/daljit it just shows a blank page.

 namespace App\Controllers;

use CodeIgniter\Controller;

class Home extends Controller
{
	public function index()
	{
		return view('welcome_message');
	}

	//--------------------------------------------------------------------
    public function daljit()
    {
        return redirect()->to("/home/hello");
    }

    public function hello()
    {
        echo "Hello!";
    }
}

CodeIgniter 4 version
CodeIgniter 4 develop branch.

[jim-parry]

Ok, the oldInput changes have been reverted, and the unit tests show that bug.
They do not show any redirect() problems.
@daljit3 Can you confirm that redirect works again, and that the old() bug is back?

[jim-parry]

Hmm - after setting the baseURL & indexPage properties in App, I get a blank page even for .../home,
although the default home apge continues to work. This may not be a redirect problem at all, but something deeper.
I have looked at the commits over the last week, and don't see what would cause this.
daljit3, when did you last pull the develop branch from the repo, before the most recent one that seems to be problematic?

[daljit3]

@jim-parry - no sorry redirect still doesn't work and I kind of rely on redirects to get to edit form page to do the testing for old(). Just for clarification, I updated my local copy again just now.

Also, I seem to have found another issue which wasn't there before but I need to investigate more what this new issue is and why I am getting this exception all of sudden as yesterday it was working. Could it be linked to that redirect issue?

CodeIgniter\HTTP\Exceptions\HTTPException 
BASEPATH/HTTP\Exceptions\HTTPException.php at line 106

daljit3, when did you last pull the develop branch from the repo, before the most recent one that seems to be problematic?

I actually update my local copy everyday using git pull and everything except old() bug worked fine.

I can confirm that this issue only started after I did git pull today after seeing your comment that it;s fixed.
I am lucky that I uploaded yesterday's code to our server and went live. I just checked and redirects work fine on my live site.

[jim-parry]

Very strange.
Now you are getting an exception isnide of the Exception class?
And whatever happened occurred over the last 24-26 hours.
Digging further here too.

[daljit3]

Very strange indeed. The reason I am so sure about that it stopped working today is, as I mentioned above, that I published my local site yesterday. My server copy isn't synced to my local as I manually ftp the changes as of now.

[daljit3]

And, because I went live, for that very reason I was doing some tests today on Sunday otherwise I wouldn't have bothered checking on a weekend.

[jim-parry]

@daljit3 I think this should solve both the redirect problem here, as well as the original old() issue.
If you could test, it would be appreciated.

[daljit3]

@jim-parry Yes just tested again:

1. redirects now work with return statment too
2. redirect blank page issue is fixed
3. Old() is working as intended i.e. correctly returns array value

However, now I see another issue (Sorry Jim! :p)
In my views I print validation errors;
<?=(service('validation')->listErrors())?>
Now, without even submitting the form, I see this line printed in an orange colored debug-view container div
1 ROOTPATH/system/Validation/Views/list.php

Also wondering what was the issue with redirects?

[natanfelles]

@daljit3 When you call the listErrors() a view is loaded.

You can check if has errors with getErrors() before to load the view.

[jim-parry]

The redirect issue was caused by my dropping the sendHeaders(), to address a different bug :-/
Solved one but caused another :(

[jim-parry]

Solution confirmed

[daljit3]

@jim-parry hi - it seems like redirects are ending on blank again!! Just updated my local copy today.