remove exception line from phpstan-baseline for RouteCollection

codeigniter4 · Sep 18, 2023 · d736bcf · d736bcf
1 parent 26c4035
commit d736bcf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -2316,11 +2316,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Router/RouteCollection.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#',
-	'count' => 2,
-	'path' => __DIR__ . '/system/Router/RouteCollection.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\Router\\\\RouteCollectionInterface\\:\\:add\\(\\) has parameter \\$to with no signature specified for Closure\\.$#',
 	'count' => 1,

diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1700,9 +1700,7 @@ public function resetRoutes()
      */
     protected function loadRoutesOptions(?string $verb = null): array
     {
-        if (null === $verb || $verb === '') {
-            $verb = $this->getHTTPVerb();
-        }
+        $verb ??= $this->getHTTPVerb();
 
         $options = $this->routesOptions[$verb] ?? [];