fix: set_checkbox() incorrect checking

set_checkbox() with default true checks unchecked checkbox when redirected back with input.
codeigniter4 · Aug 14, 2023 · d12785a · d12785a
1 parent a970e22
commit d12785a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/system/Helpers/form_helper.php b/system/Helpers/form_helper.php
@@ -629,8 +629,11 @@ function set_checkbox(string $field, string $value = '', bool $default = false):
             return '';
         }
 
+        $session     = Services::session();
+        $hasOldInput = $session->has('_ci_old_input');
+
         // Unchecked checkbox and radio inputs are not even submitted by browsers ...
-        if ((string) $input === '0' || ! empty($request->getPost()) || ! empty(old($field))) {
+        if ((string) $input === '0' || ! empty($request->getPost()) || $hasOldInput) {
             return ($input === $value) ? ' checked="checked"' : '';
         }