Skip to content

Conversation

@e-younan
Copy link
Member

@e-younan e-younan commented Jun 8, 2023

Description

This PR introduces FlashList by Shopify component.

Motivation and Context

This new component was added to unlock the power of FlashList and apply the header components from this library to it.

How Has This Been Tested?

These changes were not tested thoroughly, however, they work fine in the example shown in the example application:

Screen.Recording.2023-06-07.at.11.48.41.PM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have followed the guidelines in the README.md file.
  • I have updated the documentation as necessary.
  • My changes generate no new warnings.

Additional Notes (Optional)

This feature add requires that @shopify/flash-list is properly installed in your project. Also, the example project broke when updating react-native-reanimated to the latest version (3.2.0) and was related to react-native-reanimated#4506. The following fix cited here resolved the issue. I will dive deeper into whether or not this will create regressions for versions of react-native-reanimated < 3.3.x in this library.

@e-younan e-younan merged commit 1dac45f into main Jun 9, 2023
@e-younan e-younan deleted the feature/shopify-flashlist branch June 9, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants