Fix #16: StringSearchInterpolator does not cache answers. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
belingueres
commented
May 18, 2019
belingueres
commented
- Added tests exposing the issue.
- Fixed code.
- Added missing @OverRide annotations.
Member
|
That looks great, but could you separate the fix of override and the test into separate pull request...I appreciate to merge that...Thanks for helping.. |
Contributor
Author
|
Do you mean only the extra @OverRide in another PR? |
gnodet
approved these changes
May 5, 2024
Member
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
LGTM, the conflicts will have to be solved before merging obviously.
- Added tests exposing the issue. - Fixed code. - Added missing @OverRide annotations.
Contributor
Author
|
Rebased & squashed. |
slachiewicz
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.