Skip to content

Improve javac error output parsing - Fix #336 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Improve javac error output parsing - Fix #336 #337

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48ac162
Fix typo in JavacCompiler::parseModernStream comment
kriegaex Dec 17, 2023
4377aa9
Improve javac error output parsing
kriegaex Dec 17, 2023
ac9412f
Parametrise some error message parser tests
kriegaex Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix typo in JavacCompiler::parseModernStream comment
  • Loading branch information
@kriegaex
kriegaex committed Dec 17, 2023
commit 48ac162160bb77c9b325b4829ee7c40306bde12a
2 changes: 1 addition & 1 deletion ...plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ static List<CompilerMessage> parseModernStream(int exitCode, BufferedReader inpu

if (line == null) {
// javac output not detected by other parsing
// maybe better to ignore only the summary an mark the rest as error
// maybe better to ignore only the summary and mark the rest as error
String bufferAsString = buffer.toString();
if (buffer.length() > 0) {
if (bufferAsString.startsWith("javac:")) {
Expand Down