Skip to content

Eclipse compiler: close the StandardJavaFileManager #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Eclipse compiler: close the StandardJavaFileManager #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Eclipse compiler: close the StandardJavaFileManager 
Compare #98.
  • Loading branch information
@tomaswolf
tomaswolf committed Aug 24, 2020
commit 05299c733ff42623abf003b1d56a63939d7fa4b0
9 changes: 3 additions & 6 deletions ...piler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,19 +400,16 @@ public void report( Diagnostic<? extends JavaFileObject> diagnostic )
{
charset = Charset.defaultCharset();
}
StandardJavaFileManager manager =
compiler.getStandardFileManager( messageCollector, defaultLocale, charset );

if ( getLogger().isDebugEnabled() )
{
getLogger().debug( "ecj: using character set " + charset.displayName() );
getLogger().debug( "ecj command line: " + args );
getLogger().debug( "ecj input source files: " + allSources );
}

Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );
try
{
try ( StandardJavaFileManager manager =
compiler.getStandardFileManager( messageCollector, defaultLocale, charset ) ) {
Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );
success = Boolean.TRUE.equals(
compiler.getTask( devNull, manager, messageCollector, args, null, units ).call() );
}
Expand Down