plexus-compiler-javac-errorprone not compatible with error_prone_core 2.4.0

[viktor-thell-seal]

The compile uses the deprecated class which has been removed in 2.4.0, see commit google/error-prone@9eb414c#diff-c3084f6c295b5e983dc0963a0bec19a1

Caused by: java.lang.ClassNotFoundException: com.google.errorprone.ErrorProneCompiler
    at java.net.URLClassLoader.findClass (URLClassLoader.java:382)
    at java.lang.ClassLoader.loadClass (ClassLoader.java:418)
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$NonDelegatingClassLoader.loadClass (JavacCompilerWithErrorProne.java:138)
    at java.lang.ClassLoader.loadClass (ClassLoader.java:351)
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile (JavacCompilerWithErrorProne.java:220)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile (JavacCompilerWithErrorProne.java:91)
    at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute (AbstractCompilerMojo.java:1134)
    at org.apache.maven.plugin.compiler.CompilerMojo.execute (CompilerMojo.java:187)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

The following config was used:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-compiler-plugin</artifactId>
    <version>3.8.1</version>
    <configuration>
        <compilerId>javac-with-errorprone</compilerId>
        <forceJavacCompilerUse>true</forceJavacCompilerUse>
        <fork>true</fork>
        <source>8</source>
        <target>8</target>
        <showWarnings>true</showWarnings>
        <showDeprecation>true</showDeprecation>
        <encoding>UTF-8</encoding>
        <compilerArgs>
            <compilerArg>-XepDisableWarningsInGeneratedCode</compilerArg>
            <compilerArg>-XepExcludedPaths:.*/target/.*</compilerArg>
            <compilerArg>-Xep:WildcardImport:ERROR</compilerArg>
            <compilerArg>-Xep:RemoveUnusedImports:ERROR</compilerArg>
            <compilerArg>-Xep:DeadException:ERROR</compilerArg>
        </compilerArgs>
    </configuration>
    <dependencies>
        <dependency>
            <groupId>org.codehaus.plexus</groupId>
            <artifactId>plexus-compiler-javac-errorprone</artifactId>
            <version>2.8.6</version>
        </dependency>
        <dependency>
            <groupId>com.google.errorprone</groupId>
            <artifactId>error_prone_core</artifactId>
            <version>2.4.0</version>
        </dependency>
    </dependencies>
</plugin>

[facboy]

can this be released?

[dzou]

I'm running into this issue. What was the solution?

[facboy]

update to a newer version of plexus-compiler-javac? i think 2.8.7+ should work.

[dzou]

Hmm doesn't seem to work with the upgraded version. I get this error:

 Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile failed: A required class was missing while executing org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile: org/codehaus/plexus/compiler/javac/InProcessCompiler
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.apache.maven.plugins:maven-compiler-plugin:3.8.1
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/dzou/.m2/repository/org/apache/maven/plugins/maven-compiler-plugin/3.8.0/maven-compiler-plugin-3.8.0.jar
[ERROR] urls[1] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-compiler-javac-errorprone/2.8.8/plexus-compiler-javac-errorprone-2.8.8.jar
[ERROR] urls[2] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-utils/3.3.0/plexus-utils-3.3.0.jar
[ERROR] urls[3] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar
[ERROR] urls[4] = file:/home/dzou/.m2/repository/com/google/errorprone/error_prone_core/2.4.0/error_prone_core-2.4.0.jar
...
[ERROR] urls[40] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-compiler-api/2.8.4/plexus-compiler-api-2.8.4.jar
[ERROR] urls[41] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-compiler-manager/2.8.4/plexus-compiler-manager-2.8.4.jar
[ERROR] urls[42] = file:/home/dzou/.m2/repository/org/codehaus/plexus/plexus-compiler-javac/2.8.4/plexus-compiler-javac-2.8.4.jar

From what it looks like to me, InProcessCompiler was introduced in the latest patch 2.8.8, however maven-compiler (latest version 3.8.1 is still bringing in plexus-compiler-javac-2.8.4.jar and not version 2.8.8.

Manually updating that dependency version still doesn't work; other older versions conflict with the newer ones. Can't quite figure out the correct set of dependencies to upgrade.

I'm curious if there is an alternative to avoid using plexus-compiler-javac-errorprone.

[pzygielo]

I'm curious if there is an alternative to avoid using plexus-compiler-javac-errorprone.

plexus-compiler/README.md

Lines 11 to 15 in b81b608

	### Error Prone usage
	Please refer to [documentation](https://errorprone.info/docs/installation#maven)
	Or the project [it test](plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml)

[olamy]

depending on your java version but read here https://errorprone.info/docs/installation#maven