Skip to content

Cleanup after "veryLargeJar" test #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2023
Merged

Cleanup after "veryLargeJar" test #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/test/java/org/codehaus/plexus/archiver/jar/JarArchiverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,18 @@ public void testNonCompressed() throws IOException, ManifestException, ArchiverE
}

@Test
public void testVeryLargeJar() throws IOException, ManifestException, ArchiverException {
public void testVeryLargeJar() throws IOException, ArchiverException {
// Generate some number of random files that is likely to be
// two or three times the number of available file handles
Random rand = new Random();
for (int i = 0; i < 45000; i++) {
Path path = tempDir.resolve("file" + i);
OutputStream out = Files.newOutputStream(path);
byte[] data = new byte[512]; // 512bytes per file
rand.nextBytes(data);
out.write(data);
out.flush();
out.close();
try (OutputStream out = Files.newOutputStream(path)) {
byte[] data = new byte[512]; // 512bytes per file
rand.nextBytes(data);
out.write(data);
out.flush();
}
}

File jarFile = new File("target/output/veryLargeJar.jar");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use tempDir and file will be deleted by JUnit

Expand All @@ -75,6 +75,8 @@ public void testVeryLargeJar() throws IOException, ManifestException, ArchiverEx
archiver.setDestFile(jarFile);
archiver.addDirectory(tempDir.toFile());
archiver.createArchive();
// Clean up
Files.delete(jarFile.toPath());
}

@Test
Expand Down