add date prefix to config Chinese locales file #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
suggested changes
Jun 17, 2020
config/locales/zh-CN.yml
Outdated
| before: "必须早于 %{date}" | ||
| before_or_equal_to: "必须晚于或等于 %{date}" | ||
| equal_to: "必须等于 %{date}" | ||
| date_not_a_date: "不是一个日期" |
There was a problem hiding this comment.
This one should be not_a_date, according to the Enligh locale file:
date_validator/config/locales/en.yml
Line 4 in 48b0535
Can you change this please? 😄
There was a problem hiding this comment.
@mrcasals
Sorry for the late reply.
fixed.
Thank you 😄
mrcasals
approved these changes
Jun 23, 2020
|
Yay, thanks @Roy-Mao!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add date prefix to config Chinese locales file