fix(SelectNext): No generation of aria-describedby referencing a non-existant id in the case of a default state (#402) #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existent id in the case of a default state(codegouvfr#402)
Collaborator
|
Looks good! |
Author
|
You're welcome @garronej ! |
Collaborator
|
I did :) |
Author
|
Excellent, thanks @garronej :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voici une proposition de Pull Request pour venir corriger l'issue : #402.
Le travail a été réalisé par MBrandone pour le Select dans la PR suivante : #403 mais le problème est toujours présent sur le SelectNext.
La correction consiste donc à ne pas avoir l'attribut aria-describedby sur l'élément select quand il possède un state à "default" car aucun élément avec cet ID dans le DOM ne lui est associé.