fix: update ConfigMap name in Argo CD root path retrieval script #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaizel
approved these changes
May 26, 2025
|
/e2e |
Change the ConfigMap name from a variable to the actual name 'argocd-cmd-params-cm' in the validate-values.yaml script to ensure correct fetching of the root path. This improves clarity and prevents potential issues with undefined variables.
ATGardner
force-pushed
the
fix/argocd-validation-root-path
branch
from
fc1c8bc to
2c2ad37
Compare
|
/e2e |
mikhail-klimko
approved these changes
May 27, 2025
dmaizel
pushed a commit
that referenced
this pull request
May 28, 2025
Change the ConfigMap name from a variable to the actual name 'argocd-cmd-params-cm' in the validate-values.yaml script to ensure correct fetching of the root path. This improves clarity and prevents potential issues with undefined variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
no need for env variable - the
argocd-cmd-params-cmConfigMap name is hard-coded into argo-helm templatesWhy
the current check does not include the
ARGOCD_CM_PARAMS_NAMEenv var at all, which makes the root.path check fail (with a warning) every time. will not work if customers do use a root.path value in their byo installtion.Notes