Skip to content

CR-18557 - move createRuntime to main container #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 18, 2023
Merged

CR-18557 - move createRuntime to main container #43

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
20d2664
moved all env vars fro minitContianer to main
ATGardner May 14, 2023
d8b86d5
updated version to `0.2.4-alpha`
ATGardner May 14, 2023
a97b2b0
add `managed` env variable
ATGardner May 14, 2023
1e8ca08
simplified env vars for initContainer
ATGardner May 14, 2023
7f6fcbd
fixed test
ATGardner May 14, 2023
b656bf7
removed tests
ATGardner May 14, 2023
477d69c
set bool env var as string
ATGardner May 14, 2023
a6606a6
inject platform cert to uninstall hook
ATGardner May 16, 2023
33a97f2
added tests to pre-delete hook
ATGardner May 16, 2023
6ab6bf5
added hooks to unittest
ATGardner May 16, 2023
b78be08
added hooks to unittest
ATGardner May 16, 2023
90029d5
fixed ut template link
ATGardner May 16, 2023
e0ce16c
removed init-container env defaults
ATGardner May 17, 2023
4fbb1ca
updated comment
ATGardner May 18, 2023
753e27e
bumped app-proxy to `1.2255.0`
ATGardner May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed tests
  • Loading branch information
@ATGardner
ATGardner committed May 14, 2023
commit b656bf743655c792c1e0b235591b263f520257b5
32 changes: 0 additions & 32 deletions charts/gitops-runtime/tests/custom-ca_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,38 +121,6 @@ tests:
name: codefresh-tls-certs
readOnly: true

- it: environment variable in app-proxy init container - secret ref
template: 'app-proxy/deployment.yaml'
values:
- ./values/mandatory-values.yaml
set:
global.codefresh.tls.caCerts.secretKeyRef.name: my-secret
global.codefresh.tls.caCerts.secretKeyRef.key: my-key
asserts:
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: SSL_CERT_FILE
value: /app/config/my-secret/my-key

- it: environment variable in app-proxy init container - chart created secret
template: 'app-proxy/deployment.yaml'
values:
- ./values/mandatory-values.yaml
set:
global.codefresh.tls.caCerts.secret.create: true
global.codefresh.tls.caCerts.secret.content: |
-----BEGIN CERTIFICATE-----
... encoded certificate data here ...
-----END CERTIFICATE-----
asserts:
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: SSL_CERT_FILE
value: /app/config/codefresh-tls-certs/ca-bundle.crt


- it: events reporter sensor - check chart created secret with default key
template: event-reporters/events-reporter/sensor.yaml
values:
Expand Down
17 changes: 0 additions & 17 deletions charts/gitops-runtime/tests/installation-token_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@ tests:
set:
global.codefresh.userToken.token: dummy
asserts:
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: USER_TOKEN
valueFrom:
secretKeyRef:
name: codefresh-user-token
key: token
optional: true
- contains:
path: spec.template.spec.containers[0].env
content:
Expand All @@ -46,11 +37,3 @@ tests:
secretKeyRef:
name: mysecret
key: mykey
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: USER_TOKEN
valueFrom:
secretKeyRef:
name: mysecret
key: mykey