Skip to content

feat: enable ipv6 for internal-router #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

rbarabas
Copy link
Contributor

@rbarabas rbarabas commented Jul 21, 2023

Enables IPv6 on internal-router.

Previously, on dual stacked Kubernetes deployments internal-router would fail to start because nginx would only listen to IPv4 addresses and not IPv6. This change makes the server also listen on IPv6.

❯ kgp internal-router-6997b5f9d5-9dmpg -o wide
NAME                               READY   STATUS    RESTARTS   AGE   IP                 NODE                                                   NOMINATED NODE   READINESS GATES
internal-router-6997b5f9d5-9dmpg   1/1     Running   0          8d    2001:cafe:41::15   6e82d2e3aed918.vm.dev-k3s-cluster-sjc-01-cp.internal   <none>           <none>

❯ kgcm internal-router-config -o yaml| egrep '^[ ]+listen'
      listen 80 default_server;
      listen [::]:80 default_server;

@yaroslav-codefresh
Copy link
Member

/e2e

@yaroslav-codefresh yaroslav-codefresh merged commit 7ddc8ac into codefresh-io:main Aug 1, 2023
@yaroslav-codefresh
Copy link
Member

@rbarabas I have run e2e, approved and merged. This change will be available in the next runtime release 0.1.34 according to our release management policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants