Skip to content

CR-15471-insecure-git-providers #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 20, 2022
Merged

CR-15471-insecure-git-providers #130

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1285006
add initContainer to app-proxy
ATGardner Nov 18, 2022
c4f5eae
removed ssh hosts
ATGardner Nov 18, 2022
5ef9c6f
improve initContainer
ATGardner Nov 18, 2022
526d58c
fixed command
ATGardner Nov 18, 2022
3bcd699
removed tls-certs vol from app-proxy
ATGardner Nov 18, 2022
8187703
added missing fields
ATGardner Nov 18, 2022
e8bcaea
fix initContainer script
ATGardner Nov 20, 2022
292f7c6
removed printn after action
ATGardner Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add initContainer to app-proxy
  • Loading branch information
@ATGardner
ATGardner committed Nov 18, 2022
commit 12850060d6bf5ff7b91ba7c63e711c663318a40c
32 changes: 32 additions & 0 deletions csdp/base_components/apps/app-proxy/_components/codefresh-base/app-proxy.deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ spec:
app: cap-app-proxy
spec:
serviceAccountName: cap-app-proxy
initContainers:
- name: init-certs
image: alpine:3.16
command:
- sh
- -c
- cat /app/config/tls/* >> /app/config/all/all.cer
volumeMounts:
- mountPath: /app/config/tls
name: tls-certs
- mountPath: /app/config/all
name: all-certs
containers:
- env:
- name: ARGO_CD_URL
Expand Down Expand Up @@ -120,6 +132,8 @@ spec:
name: cap-app-proxy-cm
key: stripPrefix
optional: true
- name: NODE_EXTRA_CA_CERTS
value: /app/config/all/all.cer
image: quay.io/codefresh/cap-app-proxy
imagePullPolicy: Always
name: cap-app-proxy
Expand Down Expand Up @@ -150,3 +164,21 @@ spec:
cpu: "1500m"
securityContext:
allowPrivilegeEscalation: false
volumeMounts:
- mountPath: /app/config/ssh
name: ssh-known-hosts
- mountPath: /app/config/tls
name: tls-certs
- mountPath: /app/config/all
name: all-certs
volumes:
- name: all-certs
emptyDir: {}
- configMap:
defaultMode: 420
name: argocd-ssh-known-hosts-cm
name: ssh-known-hosts
- configMap:
defaultMode: 420
name: argocd-tls-certs-cm
name: tls-certs