chore: reporter code splitting #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets use util world instead helpers, it will keep naming consistent with ArgoCD project |
pasha-codefresh
suggested changes
Jul 3, 2024
|
|
||
| if instanceNameIncludesNs(instanceName) { | ||
| return parseInstanceName(instanceName) | ||
| } else { |
| namespace := parts[0] | ||
| app := parts[1] | ||
|
|
||
| return AppIdentity{ |
There was a problem hiding this comment.
i would return references, it is easier to operate with them
| @@ -0,0 +1,52 @@ | |||
| package reporter | |||
There was a problem hiding this comment.
i would move it to some util folder
| lastHistory := getLatestAppHistoryItem(a) | ||
|
|
||
| if lastHistory != nil { | ||
| id = lastHistory.ID |
There was a problem hiding this comment.
maybe better add return here, and not keep id as variable
| lastHistory := getLatestAppHistoryItem(a) | ||
|
|
||
| if lastHistory != nil { | ||
| revision = lastHistory.Revision |
There was a problem hiding this comment.
same here, just return and if it is not exists return a.Status.Sync.Revision
|
|
||
| func getOperationRevision(a *appv1.Application) string { | ||
| var revision string | ||
| if a != nil { |
There was a problem hiding this comment.
lets change to if a == nil { return "" } , and everything outside the block, such code will be easier to read
oleksandr-codefresh
changed the title
pasha-codefresh
approved these changes
Jul 3, 2024
oleksandr-codefresh
force-pushed
the
reporter-code-splitting
branch
from
e614d06 to
7647baa
Compare
pasha-codefresh
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: