-
Notifications
You must be signed in to change notification settings - Fork 92
New header links, and community page banner #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wittejm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled your branch and the changes look good! Just a few change requests.
| import React from "react"; | ||
| import { Link } from "react-router-dom"; | ||
| import Logo from "../Logo"; | ||
| import { forEach } from "lodash"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an unused import?
| </div> | ||
| </nav> | ||
|
|
||
| <style>{` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use tachyons for all the styling instead, to be consistent with the rest of the project? If I were doing so I would lean heavily on Claude to accomplish it 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we certainly can ! ) I will do that :)
| <div className="flex" | ||
| style={{width: "645px", maxWidth: "80vw", position: "relative", left: "-20px"}}> | ||
| <SVG | ||
| name="oregonMap2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we call this oregonSilhouette (and rename the component below to match), to be a little more clear what it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good!
Community page banner, header links and collapsing menu on mobile (<1000px), and an extra svg in the svg's component~