Skip to content

Conversation

@hermannsalan
Copy link
Contributor

Community page banner, header links and collapsing menu on mobile (<1000px), and an extra svg in the svg's component~

Copy link
Contributor

@wittejm wittejm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your branch and the changes look good! Just a few change requests.

import React from "react";
import { Link } from "react-router-dom";
import Logo from "../Logo";
import { forEach } from "lodash";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an unused import?

</div>
</nav>

<style>{`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use tachyons for all the styling instead, to be consistent with the rest of the project? If I were doing so I would lean heavily on Claude to accomplish it 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we certainly can ! ) I will do that :)

<div className="flex"
style={{width: "645px", maxWidth: "80vw", position: "relative", left: "-20px"}}>
<SVG
name="oregonMap2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we call this oregonSilhouette (and rename the component below to match), to be a little more clear what it is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good!

@wittejm wittejm merged commit 0469445 into codeforpdx:master Jan 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants