Skip to content
This repository was archived by the owner on Dec 19, 2021. It is now read-only.

Conversation

@NickSchimek
Copy link
Member

@NickSchimek NickSchimek commented Oct 17, 2021

Sometimes the logging is useful, but other times it just gets in the
way. Enable the user to turn off/on logging as they desire from their
.env file.

For example when tests fail you'll often see large output from this logger, which can be helpful sometimes, but most of the time you just want to see the failure message.

@NickSchimek NickSchimek self-assigned this Oct 17, 2021
Sometimes the logging is useful, but other times it just gets in the
way. Enable the user to turn off/on logging as they desire from their
.env file.
TNorbury
TNorbury previously approved these changes Oct 17, 2021
Copy link
Contributor

@TNorbury TNorbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

aedwardg
aedwardg previously approved these changes Oct 17, 2021
Co-authored-by: Tyler Norbury <TNorbury@users.noreply.github.com>
@NickSchimek NickSchimek dismissed stale reviews from aedwardg and TNorbury via 3cfba76 October 18, 2021 02:06
@NickSchimek NickSchimek merged commit d68c804 into development Oct 18, 2021
@NickSchimek NickSchimek deleted the conditional_logging branch October 18, 2021 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants