Add MFA support for IBM i 7.6 #3036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Contributor
|
👋 A new build is available for this PR based on 4c53b75. |
| callbacks.progress({ | ||
| message: `Prompting for one-time password.` | ||
| }); | ||
| const oneTimePassword = await options.callbacks.inputBox(`Enter your one-time password or press "Enter" if within your TOTP interval`, `One-Time Password`, true); |
There was a problem hiding this comment.
I think the terminology should be reviewed.
'one-time password' is not completely correct since it is actually 'time-based one-time password' (TOTP) value.
We should consider what is shown in 5250 and ACS which I think is 'Additional factor'. Consistency would be easier on users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new login setting to enable MFA when connecting:
When enabled, this will prompt the user for their TOTP which will be appended to the password when connecting via SSH (
<password>:<totp>):For users that have their
TOTP optional intervalset, you can also just press theEnterkey to proceed without entering the TOTP.This PR also resolves 2 other issues related to hitting
Cancelin the progress bar when connecting:Cancelright away, the progress bar goes away, but it still does all connect steps (check theCode for IBM ioutput channel). Now it properly cancels the connection attemptCancel, you often would get aCannot read properties of undefined (reading 'execCommand'). Now it properly notifies the user:Connection attempt cancelled.Updates to docs: codefori/docs#88
How to test this PR
Scenarios to test:
TOTP optional intervalset, reconnect and pressEnterwhen prompted for the TOTP. It should still connect successfully.Cancelrelated fixes by trying the scenarios I mentioned.Checklist