Skip to content

Filter and stars #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

Filter and stars #401

merged 4 commits into from
Jun 4, 2025
+113 −41

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Jun 4, 2025 •
edited
Loading

  • Adds ability to filter statement history using pre-existing VS Code UI
  • New buttons to star/unstar history items, and add a new node under history to see all starred items
  • Additional warning button on clearing all history
image

@worksofliam
Better ability to filter statements
f3e75d2 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Remove legacy query data
949b797 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Add ability to star and unstar query history
7c338d0 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
New star node for featured items
a8c3dd2 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

👋 A new build is available for this PR based on a8c3dd2.

@worksofliam
Copy link
Contributor Author

@dferrand Is this something you'd like to have a go at?

@dferrand
Copy link
Contributor

dferrand commented Jun 4, 2025

@dferrand Is this something you'd like to have a go at?

Do you mean reviewing it?

@worksofliam
Copy link
Contributor Author

@dferrand I am sorry, I tagged the wrong person. if you'd like to review you are welcome.

I was supposed to tag @janfh.

janfh
janfh approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@janfh janfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Tested and worked fine

@worksofliam
Copy link
Contributor Author

@janfh Thank you!!

@worksofliam worksofliam merged commit ed221c1 into main Jun 4, 2025
1 check passed
forstie
forstie reviewed Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are working well for me.
Well done

@worksofliam worksofliam linked an issue Jun 6, 2025 that may be closed by this pull request
Please add the Filter support to Statement History #399
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstie forstie forstie left review comments

@janfh janfh janfh approved these changes

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add the Filter support to Statement History
4 participants
@worksofliam @dferrand @forstie @janfh