Skip to content

Display time to execute when running SQL statements #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Display time to execute when running SQL statements #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2577335
Display time to execute when running SQL statements
RobertNash1 Mar 18, 2025
dc87e83
Changed so the execution time only runs on the first execute call
RobertNash1 Mar 20, 2025
c2baaf5
Resolved the issue where a string was being compared to a number
RobertNash1 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/views/results/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,12 @@ export function generateScroller(basicSelect: string, isCL: boolean, withCancel?
if (data.rows === undefined && totalRows === 0) {
document.getElementById(messageSpanId).innerText = 'Statement executed with no result set returned. Rows affected: ' + data.update_count;
} else {
document.getElementById(statusId).innerText = (noMoreRows ? ('Loaded ' + totalRows + '. End of data.') : ('Loaded ' + totalRows + '. More available.')) + ' ' + (updateTable ? 'Updatable.' : '');
if (data.executionTime) {
document.getElementById(statusId).innerText = (noMoreRows ? ('Loaded ' + totalRows + ' rows in ' + data.executionTime.toFixed() + 'ms. End of data.') : ('Loaded ' + totalRows + ' rows in ' + data.executionTime.toFixed() + 'ms. More available.')) + ' ' + (updateTable ? 'Updatable.' : '');
}
else {
document.getElementById(statusId).innerText = (noMoreRows ? ('Loaded ' + totalRows + ' rows. End of data.') : ('Loaded ' + totalRows + ' rows. More available.')) + ' ' + (updateTable ? 'Updatable.' : '');
}
document.getElementById(jobId).innerText = data.jobId ? data.jobId : '';
document.getElementById(messageSpanId).style.visibility = "hidden";
}
Expand Down
18 changes: 15 additions & 3 deletions src/views/results/resultSetPanelProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,20 @@ export class ResultSetPanelProvider implements WebviewViewProvider {

if (this.currentQuery.getState() !== "RUN_DONE") {
setCancelButtonVisibility(true);
let queryResults = undefined;
let startTime = 0;
let endTime = 0;
let executionTime: number|undefined;

let queryResults = this.currentQuery.getState() == "RUN_MORE_DATA_AVAILABLE" ? await this.currentQuery.fetchMore() : await this.currentQuery.execute();

if (this.currentQuery.getState() == "RUN_MORE_DATA_AVAILABLE") {
queryResults = await this.currentQuery.fetchMore();
}
else {
startTime = performance.now();
queryResults = await this.currentQuery.execute();
endTime = performance.now();
executionTime = (endTime - startTime)
}
const jobId = this.currentQuery.getHostJob().id;

this._view.webview.postMessage({
Expand All @@ -112,7 +123,8 @@ export class ResultSetPanelProvider implements WebviewViewProvider {
columnHeadings: Configuration.get(`resultsets.columnHeadings`) || 'Name',
queryId: this.currentQuery.getId(),
update_count: queryResults.update_count,
isDone: queryResults.is_done
isDone: queryResults.is_done,
executionTime
});
}

Expand Down