Skip to content

Cleanup API changes and fix ASP info #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/base.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { CodeForIBMi } from "@halcyontech/vscode-ibmi-types";
import Instance from "@halcyontech/vscode-ibmi-types/api/Instance";
import {CustomUI} from "@halcyontech/vscode-ibmi-types/api/CustomUI";
import Instance from "@halcyontech/vscode-ibmi-types/Instance";
import { Extension, ExtensionContext, extensions } from "vscode";
import { SQLStatementChecker } from "./connection/syntaxChecker";

Expand Down
2 changes: 1 addition & 1 deletion src/connection/syntaxChecker/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import IBMi from "@halcyontech/vscode-ibmi-types/api/IBMi";
import { ComponentIdentification, ComponentState, IBMiComponent } from "@halcyontech/vscode-ibmi-types/components/component";
import { ComponentIdentification, ComponentState, IBMiComponent } from "@halcyontech/vscode-ibmi-types/api/components/component";
import { posix } from "path";
import { getValidatorSource, VALIDATOR_NAME, WRAPPER_NAME } from "./checker";
import { JobManager } from "../../config";
Expand Down
2 changes: 1 addition & 1 deletion src/views/jobManager/editJob/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { getBase } from "../../../base";
import { JDBCOptions } from "@ibm/mapepire-js/dist/src/types";
import { ComplexTab } from "@halcyontech/vscode-ibmi-types/api/CustomUI";
import { ComplexTab } from "@halcyontech/vscode-ibmi-types/webviews/CustomUI";

import getPerfTab from "./perfTab";
import getFormatTab from "./formatTab";
Expand Down
9 changes: 1 addition & 8 deletions src/views/jobManager/editJob/systemTab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@ import { JDBCOptions } from "@ibm/mapepire-js/dist/src/types";
import { getBase, getInstance, loadBase } from "../../../base";
import { formatDescription } from ".";

const autoCommitText = `
Specifies the cursor sensitivity to request from the database. The behavior depends on the resultSetType:
- ResultSet.TYPE_FORWARD_ONLY or ResultSet.TYPE_SCROLL_SENSITIVE means that the value of this property
controls what cursor sensitivity the Java program requests from the database.
- ResultSet.TYPE_SCROLL_INSENSITIVE causes this property to be ignored.
`;

const dbNameText = `

Specifies the database to use for a connection to an independent auxiliary storage pool (ASP). When you specify
Expand Down Expand Up @@ -129,7 +122,7 @@ export default function getSystemTab(options: JDBCOptions) {
// )
.addSelect(`database name`, `Database name`, [
{text: `System Base`, description: `*SYSBAS`, value: ``, selected: options["database name"] === ``},
...Object.values(connection.aspInfo).map(asp => ({text: asp, description: asp, value: asp, selected: options["database name"] === asp}))
...Object.values(connection.getAllIAsps()).map(asp => ({text: asp.name, description: asp.name, value: asp.rdbName, selected: options["database name"] === asp.rdbName}))
], formatDescription(dbNameText))
.addSelect(
`decfloat rounding mode`,
Expand Down
Loading