Issue 478 add agency search page #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesg8025
force-pushed
the
issue-478-add-agency-search-page
branch
from
14d219e to
eba6116
Compare
jamesg8025
force-pushed
the
issue-478-add-agency-search-page
branch
from
eba6116 to
c7e4f5f
Compare
jamesg8025
changed the title
cyng24
reviewed
Dec 8, 2025
| import { useSearchParams } from "next/navigation" | ||
| import { SearchResponse, AgencyResponse } from "@/utils/api" | ||
| import { useSearch } from "@/providers/SearchProvider" | ||
| import { useEffect } from "react" |
Collaborator
There was a problem hiding this comment.
Can you add this to line 3 to consolidate imports?
Comment on lines
25
to
43
| useEffect(() => { | ||
| const performAgencySearch = async () => { | ||
| if (tab !== 3 || !currentQuery) return | ||
|
|
||
| setAgencyLoading(true) | ||
| try { | ||
| const response = await searchAgencies({ name: currentQuery }) | ||
| setAgencyResults(response.results || []) | ||
| setAgencyTotal(response.total || 0) | ||
| } catch (error) { | ||
| console.error('Agency search failed:', error) | ||
| setAgencyResults([]) | ||
| setAgencyTotal(0) | ||
| } finally { | ||
| setAgencyLoading(false) | ||
| } | ||
| } | ||
| performAgencySearch() | ||
| }, [currentQuery, tab, searchAgencies]) |
Collaborator
There was a problem hiding this comment.
Since I'm going to be adding a unit search on the same page, I'm wondering if this is the best place to have all the logic.
Could you move performAgencySearch outside the useEffect and then do the tab check?
useEffect(() => {
if (tab === 3) performAgencySearch();
if (tab === other_tabs) performOtherTabSearch(); // so we can list all the functions clearly
}, [currentQuery, tab]);
Collaborator
There was a problem hiding this comment.
Also would probably be good to have a debounce for currentQuery changes so we aren't calling search for every keystroke.
Comment on lines
+115
to
+126
| <CustomTabPanel value={tab} index={3}> | ||
| {agencyLoading ? ( | ||
| <Typography>Searching agencies...</Typography> | ||
| ) : ( | ||
| <> | ||
| <Typography sx={{ marginBottom: "1rem", fontWeight: "bold" }}> | ||
| {agencyTotal} agency results | ||
| </Typography> | ||
| {agencyResults.map((result) => ( | ||
| <CardHeader |
Collaborator
There was a problem hiding this comment.
Similar to my other comment:
I'm wondering if we can move this into another component that can be customized according to what's being searched. That way we don't have all these hardcoded (by agency, but unit, etc) CustomTabPanels.
I don't know if you want to do this or I can make that change when I start my Unit Search task.
Add more debug logs to observe results data structure Add Agency tab with basic result filtering - Filter existing search results by content_type === 'Agency' - Does not handle officer-to-agency searches yet Add agencies API integration Implement Agency tab with a dedicated agencies API endpoint - Add /agencies endpoint to apiRoutes - Add searchAgencies function to SearchProvider - Update Agency tab to call agencies API when selected - Encountered CORS error Fix Agency search results - Fixed agency endpoint - Return proper agency information - Adjust Agency info card rendering in search results Add useEffect for reactive agency search state and remove debug logs
- Better scalability for future tab functions - Also consolidated React imports
jamesg8025
force-pushed
the
issue-478-add-agency-search-page
branch
from
c7e4f5f to
adcd2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements agency tab functionality with dedicated '/agencies/' API endpoint.