- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Instrument middleware to emit OTel metrics #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a150265    to
    8f46683      
    Compare
  
    40cf8ed    to
    c59dfc6      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds OpenTelemetry (OTel) instrumentation to the consumer, redoer, and exporter services to track metrics for message processing, export operations, and queue counts. The changes also include a minor Docker Compose fix for service health checks.
- Added OTel metrics collection with configurable exporters (Console or OTLP)
 - Instrumented three middleware services to track operation counts, durations, and status
 - Added environment variable support for runtime environment identification
 
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description | 
|---|---|
| middleware/otel.py | New module providing OTel initialization and common constants for status tracking | 
| middleware/redoer.py | Added OTel metrics for redo message processing and queue monitoring | 
| middleware/exporter.py | Added OTel metrics for export operation tracking | 
| middleware/consumer.py | Added OTel metrics for consumer message processing | 
| Dockerfile.redoer | Installed OpenTelemetry packages | 
| Dockerfile.exporter | Installed OpenTelemetry packages | 
| Dockerfile.consumer | Installed OpenTelemetry packages and enabled logging auto-instrumentation | 
| docker-compose.yaml | Fixed depends_on syntax to use health check condition | 
| README.md | Documented new OTel environment variables | 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks sound. Copilot found a few small things, please address before merging.
b21c053    to
    efa96a2      
    Compare
  
    
Add OTel metrics:
otel.pymodule addedAncillary: