Skip to content

⚡️ Speed up method Route.matches by 13% #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Route.matches by 13% #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions starlette/routing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,9 @@ def __init__(
if methods is None:
self.methods = None
else:
self.methods = {method.upper() for method in methods}
self.methods = set()
for method in methods:
self.methods.add(method.upper())
if "GET" in self.methods:
self.methods.add("HEAD")

Expand All @@ -252,14 +254,26 @@ def __init__(
def matches(self, scope: Scope) -> tuple[Match, Scope]:
path_params: dict[str, Any]
if scope["type"] == "http":
route_path = get_route_path(scope)
path = scope.get("path", None)
root_path = scope.get("root_path", "")
if path is None:
route_path = get_route_path(scope)
elif not root_path:
route_path = path
else:
route_path = get_route_path(scope)

match = self.path_regex.match(route_path)
if match:
matched_params = match.groupdict()
for key, value in matched_params.items():
matched_params[key] = self.param_convertors[key].convert(value)
path_params = dict(scope.get("path_params", {}))
path_params.update(matched_params)
for key in matched_params:
matched_params[key] = self.param_convertors[key].convert(matched_params[key])
path_params = scope.get("path_params")
if path_params:
path_params = dict(path_params)
path_params.update(matched_params)
else:
path_params = matched_params
child_scope = {"endpoint": self.endpoint, "path_params": path_params}
if self.methods and scope["method"] not in self.methods:
return Match.PARTIAL, child_scope
Expand Down