Skip to content

⚡️ Speed up method MultiDict.setdefault by 24% #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MultiDict.setdefault by 24% #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions starlette/datastructures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,11 +349,16 @@ def clear(self) -> None:
self._list.clear()

def setdefault(self, key: Any, default: Any = None) -> Any:
if key not in self:
self._dict[key] = default
# Try to access self._dict directly for improved lookup performance
# (preserving behavior since ImmutableMultiDict.__getitem__ and __contains__ both delegate to self._dict)
_dict = self._dict # local variable lookup optimization

if key not in _dict:
_dict[key] = default
self._list.append((key, default))

return self[key]
# Access dict directly for the return path to avoid double lookup
return _dict[key]

def setlist(self, key: Any, values: list[Any]) -> None:
if not values:
Expand Down