Skip to content

⚡️ Speed up function has_level_label by 76% #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

⚡️ Speed up function has_level_label by 76% #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pandas/plotting/_matplotlib/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def wrapper(*args, **kwargs):
with pandas_converters():
return func(*args, **kwargs)

return cast(F, wrapper)
return cast("F", wrapper)


@contextlib.contextmanager
Expand Down Expand Up @@ -512,12 +512,14 @@ def has_level_label(label_flags: npt.NDArray[np.intp], vmin: float) -> bool:
if the minimum view limit is not an exact integer, then the first tick
label won't be shown, so we must adjust for that.
"""
if label_flags.size == 0 or (
label_flags.size == 1 and label_flags[0] == 0 and vmin % 1 > 0.0
):
size = label_flags.size
if size == 0:
return False
else:
return True
if size == 1:
val = label_flags.item()
if val == 0 and vmin % 1 > 0.0:
return False
return True


def _get_periods_per_ymd(freq: BaseOffset) -> tuple[int, int, int]:
Expand Down