Skip to content

⚡️ Speed up function _valid_locales by 16% #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _valid_locales by 16% #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions pandas/_config/localization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,11 @@ def can_set_locale(lc: str, lc_var: int = locale.LC_ALL) -> bool:
Whether the passed locale can be set
"""
try:
with set_locale(lc, lc_var=lc_var):
pass
current_locale = locale.setlocale(lc_var)
try:
locale.setlocale(lc_var, lc)
finally:
locale.setlocale(lc_var, current_locale)
except (ValueError, locale.Error):
# horrible name for a Exception subclass
return False
Expand All @@ -102,14 +105,12 @@ def _valid_locales(locales: list[str] | str, normalize: bool) -> list[str]:
valid_locales : list
A list of valid locales.
"""
return [
loc
for loc in (
locale.normalize(loc.strip()) if normalize else loc.strip()
for loc in locales
)
if can_set_locale(loc)
]
valid_locales = []
for loc in locales:
loc = locale.normalize(loc.strip()) if normalize else loc.strip()
if can_set_locale(loc):
valid_locales.append(loc)
return valid_locales


def get_locales(
Expand Down Expand Up @@ -156,7 +157,9 @@ def get_locales(
out_locales = []
for x in split_raw_locales:
try:
out_locales.append(str(x, encoding=cast(str, options.display.encoding)))
out_locales.append(
str(x, encoding=cast("str", options.display.encoding))
)
except UnicodeError:
# 'locale -a' is used to populated 'raw_locales' and on
# Redhat 7 Linux (and maybe others) prints locale names
Expand Down