Skip to content

⚡️ Speed up method Categorical._categories_match_up_to_permutation by 331% #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Categorical._categories_match_up_to_permutation by 331% #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/core/arrays/categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2473,7 +2473,7 @@ def _mode(self, dropna: bool = True) -> Categorical:
mask = self.isna()

res_codes = algorithms.mode(codes, mask=mask)
res_codes = cast(np.ndarray, res_codes)
res_codes = cast("np.ndarray", res_codes)
assert res_codes.dtype == codes.dtype
res = self._from_backing_data(res_codes)
return res
Expand Down Expand Up @@ -2614,7 +2614,9 @@ def _categories_match_up_to_permutation(self, other: Categorical) -> bool:
-------
bool
"""
return hash(self.dtype) == hash(other.dtype)
# Optimized: call __eq__ directly, which avoids two hash computations and
# is a cheap equality test (faster than hashing for CategoricalDtype)
return self.dtype == other.dtype

def describe(self) -> DataFrame:
"""
Expand Down