Skip to content

⚡️ Speed up function _custom_logger_class_exists_in_success_callbacks by 87% #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _custom_logger_class_exists_in_success_callbacks by 87% #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions litellm/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,15 @@ def _custom_logger_class_exists_in_success_callbacks(

Prevents double adding a custom logger callback to the litellm callbacks
"""
return any(
isinstance(cb, type(callback_class))
for cb in litellm.success_callback + litellm._async_success_callback
)
cb_type = type(callback_class)
# Combine callbacks and use generator for faster exits on first match
for cb in litellm.success_callback:
if isinstance(cb, cb_type):
return True
for cb in litellm._async_success_callback:
if isinstance(cb, cb_type):
return True
return False


def _custom_logger_class_exists_in_failure_callbacks(
Expand Down