⚡️ Speed up method VertexBase._credentials_from_service_account by 15%

[codeflash-ai]

📄 15% (0.15x) speedup for VertexBase._credentials_from_service_account in litellm/llms/vertex_ai/vertex_llm_base.py

⏱️ Runtime : 10.1 microseconds → 8.79 microseconds (best of 15 runs)

📝 Explanation and details

The optimization moves the import google.oauth2.service_account statement from inside the _credentials_from_service_account method to module-level, eliminating repeated import overhead on every function call.

Key changes:

• Moved the Google OAuth import to module-level scope
• Created a helper function _service_account_creds that wraps the credential creation logic
• The method now simply calls the helper function instead of importing and calling directly

Why this speeds up the code:
Python's import system has overhead even for already-cached modules. The line profiler shows the import statement consumed 98.3% of the original function's execution time (104ms out of 106ms total). By moving the import to module-level, this overhead is paid only once when the module loads, rather than on every method invocation.

Test case performance:
The optimization provides consistent 14-15% speedup across all test scenarios, from basic validation cases to error handling paths. This improvement is particularly valuable for applications that frequently create service account credentials, as the per-call overhead reduction compounds with usage frequency.

The optimization maintains identical behavior and error handling while eliminating a significant performance bottleneck in credential creation workflows.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 40 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests and Runtime

import sys
import types

# imports
import pytest  # used for our unit tests
from litellm.llms.vertex_ai.vertex_llm_base import VertexBase


# --- Begin: Function to test (self-contained implementation) ---
class DummyGoogleCredentials:
    """Dummy credentials class to simulate google.oauth2.service_account.Credentials behavior."""
    def __init__(self, info, scopes):
        # Store info and scopes for verification
        self.info = info
        self.scopes = scopes

    @classmethod
    def from_service_account_info(cls, json_obj, scopes=None):
        # Simulate error if required fields are missing
        required_keys = ["client_email", "private_key", "token_uri"]
        for key in required_keys:
            if key not in json_obj:
                raise ValueError(f"Missing required field: {key}")
        # Simulate error if scopes is not a list or tuple
        if scopes is not None and not isinstance(scopes, (list, tuple)):
            raise TypeError("Scopes must be a list or tuple")
        # Simulate error if private_key is empty
        if not json_obj.get("private_key"):
            raise ValueError("private_key cannot be empty")
        return cls(json_obj, scopes)
from litellm.llms.vertex_ai.vertex_llm_base import VertexBase

# --- End: Function to test ---


# --- Begin: Unit Tests ---

# Basic Test Cases




def test_missing_client_email():
    """Test with missing client_email field."""
    vb = VertexBase()
    json_obj = {
        "private_key": "some-key",
        "token_uri": "https://oauth2.googleapis.com/token"
    }
    scopes = ["scope"]
    with pytest.raises(ValueError, match="Missing required field: client_email"):
        vb._credentials_from_service_account(json_obj, scopes)

def test_missing_private_key():
    """Test with missing private_key field."""
    vb = VertexBase()
    json_obj = {
        "client_email": "test@example.com",
        "token_uri": "https://oauth2.googleapis.com/token"
    }
    scopes = ["scope"]
    with pytest.raises(ValueError, match="Missing required field: private_key"):
        vb._credentials_from_service_account(json_obj, scopes)

def test_missing_token_uri():
    """Test with missing token_uri field."""
    vb = VertexBase()
    json_obj = {
        "client_email": "test@example.com",
        "private_key": "some-key"
    }
    scopes = ["scope"]
    with pytest.raises(ValueError, match="Missing required field: token_uri"):
        vb._credentials_from_service_account(json_obj, scopes)




def test_empty_json_obj():
    """Test with completely empty JSON object."""
    vb = VertexBase()
    json_obj = {}
    scopes = ["scope"]
    with pytest.raises(ValueError, match="Missing required field: client_email"):
        vb._credentials_from_service_account(json_obj, scopes)

def test_none_json_obj():
    """Test with None as JSON object."""
    vb = VertexBase()
    json_obj = None
    scopes = ["scope"]
    with pytest.raises(TypeError):
        vb._credentials_from_service_account(json_obj, scopes)

def test_none_scopes_and_missing_fields():
    """Test with None scopes and missing fields."""
    vb = VertexBase()
    json_obj = {}
    scopes = None
    with pytest.raises(ValueError):
        vb._credentials_from_service_account(json_obj, scopes) # 10.1μs -> 8.79μs (14.7% faster)

# Large Scale Test Cases





#------------------------------------------------
import sys
import types

# imports
import pytest  # used for our unit tests
from litellm.llms.vertex_ai.vertex_llm_base import VertexBase


# function to test
class DummyCredentials:
    """A dummy class to simulate google.oauth2.service_account.Credentials"""
    def __init__(self, info, scopes):
        self.info = info
        self.scopes = scopes

    @classmethod
    def from_service_account_info(cls, json_obj, scopes=None):
        # Simulate required fields
        required_fields = ["type", "project_id", "private_key_id", "private_key", "client_email", "client_id", "auth_uri", "token_uri", "auth_provider_x509_cert_url", "client_x509_cert_url"]
        if not isinstance(json_obj, dict):
            raise ValueError("Service account info must be a dict")
        for field in required_fields:
            if field not in json_obj:
                raise ValueError(f"Missing required field: {field}")
        if scopes is None:
            scopes = []
        if not isinstance(scopes, (list, tuple)):
            raise ValueError("Scopes must be a list or tuple")
        for scope in scopes:
            if not isinstance(scope, str) or not scope:
                raise ValueError("Scopes must be non-empty strings")
        return cls(json_obj, scopes)
from litellm.llms.vertex_ai.vertex_llm_base import VertexBase


# Helper: valid service account dict
def valid_service_account_info():
    return {
        "type": "service_account",
        "project_id": "test-project",
        "private_key_id": "somekeyid",
        "private_key": "-----BEGIN PRIVATE KEY-----\nMIIEvQIBADANBgkqhkiG9w0BAQEFAASC...",
        "client_email": "test@test-project.iam.gserviceaccount.com",
        "client_id": "1234567890",
        "auth_uri": "https://accounts.google.com/o/oauth2/auth",
        "token_uri": "https://oauth2.googleapis.com/token",
        "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
        "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/test@test-project.iam.gserviceaccount.com"
    }

# --------------------------
# UNIT TESTS
# --------------------------

# 1. BASIC TEST CASES





def test_missing_field_in_service_account():
    """Test with missing required field in service account info."""
    vb = VertexBase()
    info = valid_service_account_info()
    del info["private_key"]
    scopes = ["https://www.googleapis.com/auth/cloud-platform"]
    with pytest.raises(ValueError, match="Missing required field: private_key"):
        vb._credentials_from_service_account(info, scopes)

def test_service_account_info_not_dict():
    """Test with service account info not a dict."""
    vb = VertexBase()
    info = "not a dict"
    scopes = ["https://www.googleapis.com/auth/cloud-platform"]
    with pytest.raises(ValueError, match="Service account info must be a dict"):
        vb._credentials_from_service_account(info, scopes)

To edit these changes git checkout codeflash/optimize-VertexBase._credentials_from_service_account-mhdatu20 and push.