Skip to content

minor modification for checking replay tests passing #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

minor modification for checking replay tests passing #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codeflash/result/critic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def quantity_of_tests_critic(candidate_result: OptimizedCandidateResult) -> bool

if pass_count >= MIN_TESTCASE_PASSED_THRESHOLD:
return True
# If only one test passed, check if it's a REPLAY_TEST
return bool(pass_count == 1 and report[TestType.REPLAY_TEST]["passed"] == 1)
# If one or more tests passed, check if least one of them was a successful REPLAY_TEST
return bool(pass_count >= 1 and report[TestType.REPLAY_TEST]["passed"] >= 1)


def coverage_critic(original_code_coverage: CoverageData | None, test_framework: str) -> bool:
Expand Down
Loading