Skip to content

Conversation

@misrasaurabh1
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 commented May 20, 2025

PR Type

Enhancement


Description

  • Reordered and cleaned imports for clarity

  • Updated logger debug message wording

  • Fixed spacing in comparison and removed blank line

  • Reformatted multi-line assert for readability


Changes walkthrough 📝

Relevant files
Formatting
aiservice.py
Refactor imports and improve logging                                         

codeflash/api/aiservice.py

  • moved time import below other imports
  • changed debug log to "Generating optimizations took..."
  • added spaces around == in if line_profiler_results
  • reformatted assert test_framework as multi-line list
  • removed unnecessary blank line before log_results
  • +7/-8     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Runtime Assertion

    Using assert for validating test_framework can be skipped in optimized mode; consider raising a ValueError instead.

    assert test_framework in [
        "pytest",
        "unittest",
    ], f"Invalid test framework, got {test_framework} but expected 'pytest' or 'unittest'"

    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @misrasaurabh1 misrasaurabh1 merged commit 8ffb274 into main May 20, 2025
    16 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants