Skip to content

Fix loop ending when all candidates have been tested but line profiler hasn't returned new candidates #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Fix loop ending when all candidates have been tested but line profiler hasn't returned new candidates #226

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
766c319
trying
aseembits93 May 19, 2025
87822c1
should work now
aseembits93 May 19, 2025
efa767c
fix rare case when line profiler aiservice returns an empty list
aseembits93 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions codeflash/optimization/function_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ def determine_best_candidate(
try:
candidate_index = 0
original_len = len(candidates)
while candidates:
while True:
done = True if future_line_profile_results is None else future_line_profile_results.done()
if done and (future_line_profile_results is not None):
line_profile_results = future_line_profile_results.result()
Expand All @@ -403,8 +403,13 @@ def determine_best_candidate(
f"Added results from line profiler to candidates, total candidates now: {original_len}"
)
future_line_profile_results = None
try:
candidate = candidates.popleft()
except IndexError as e:
if done:
break
continue
candidate_index += 1
candidate = candidates.popleft()
get_run_tmp_file(Path(f"test_return_values_{candidate_index}.bin")).unlink(missing_ok=True)
get_run_tmp_file(Path(f"test_return_values_{candidate_index}.sqlite")).unlink(missing_ok=True)
logger.info(f"Optimization candidate {candidate_index}/{original_len}:")
Expand Down Expand Up @@ -512,7 +517,8 @@ def determine_best_candidate(
self.write_code_and_helpers(
self.function_to_optimize_source_code, original_helper_code, self.function_to_optimize.file_path
)

if done and not candidates:
break
except KeyboardInterrupt as e:
self.write_code_and_helpers(
self.function_to_optimize_source_code, original_helper_code, self.function_to_optimize.file_path
Expand Down
Loading