Skip to content

go fish #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion codeflash/code_utils/coverage_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,18 @@ def extract_dependent_function(main_function: str, code_context: CodeOptimizatio
if len(dependent_functions) != 1:
return False

return dependent_functions.pop()
return build_fully_qualified_name(dependent_functions.pop(), code_context)


def build_fully_qualified_name(function_name: str, code_context: CodeOptimizationContext) -> str:
full_name = function_name
for obj_name, parents in code_context.preexisting_objects:
if obj_name == function_name:
for parent in parents:
if parent.type == "ClassDef":
full_name = f"{parent.name}.{full_name}"
break
return full_name


def generate_candidates(source_code_path: Path) -> list[str]:
Expand Down
21 changes: 13 additions & 8 deletions codeflash/models/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@

from codeflash.cli_cmds.console import console, logger
from codeflash.code_utils.code_utils import validate_python_code
from codeflash.code_utils.coverage_utils import extract_dependent_function, generate_candidates
from codeflash.code_utils.coverage_utils import (
build_fully_qualified_name,
extract_dependent_function,
generate_candidates,
)
from codeflash.code_utils.env_utils import is_end_to_end
from codeflash.verification.test_results import TestResults, TestType

Expand Down Expand Up @@ -322,18 +326,19 @@ def _fetch_function_coverages(
coverage_data: dict[str, dict[str, Any]],
original_cov_data: dict[str, dict[str, Any]],
) -> tuple[FunctionCoverage, Union[FunctionCoverage, None]]:
resolved_name = build_fully_qualified_name(function_name, code_context)
try:
main_function_coverage = FunctionCoverage(
name=function_name,
coverage=coverage_data[function_name]["summary"]["percent_covered"],
executed_lines=coverage_data[function_name]["executed_lines"],
unexecuted_lines=coverage_data[function_name]["missing_lines"],
executed_branches=coverage_data[function_name]["executed_branches"],
unexecuted_branches=coverage_data[function_name]["missing_branches"],
name=resolved_name,
coverage=coverage_data[resolved_name]["summary"]["percent_covered"],
executed_lines=coverage_data[resolved_name]["executed_lines"],
unexecuted_lines=coverage_data[resolved_name]["missing_lines"],
executed_branches=coverage_data[resolved_name]["executed_branches"],
unexecuted_branches=coverage_data[resolved_name]["missing_branches"],
)
except KeyError:
main_function_coverage = FunctionCoverage(
name=function_name,
name=resolved_name,
coverage=0,
executed_lines=[],
unexecuted_lines=[],
Expand Down
Loading