Skip to content

fix: improve worktree path handling for cross-platform compatibility #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mashraf-222 merged 2 commits into from
Jan 9, 2026
Merged

fix: improve worktree path handling for cross-platform compatibility #1035

mashraf-222 merged 2 commits into from
Jan 9, 2026

Conversation

@mashraf-222
Copy link
Contributor

@mashraf-222 mashraf-222 commented Jan 9, 2026

Fix: Support Windows paths in worktree path simplification

Fixed simplify_worktree_paths to handle Windows paths. The regex only matched Unix-style paths, and path splitting used / only.

Changes:

  • Updated regex to match both forward and backslashes
  • Replaced split("/") with Path(...).name for cross-platform path handling

Works on both Unix and Windows without changing behavior.

@mashraf-222 mashraf-222 merged commit 524c0d3 into main Jan 9, 2026
23 of 24 checks passed
@mashraf-222 mashraf-222 deleted the fix/worktree-path-highlighted-windows branch January 9, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohammedahmed18 mohammedahmed18 mohammedahmed18 approved these changes

@Saga4 Saga4 Awaiting requested review from Saga4

@HeshamHM28 HeshamHM28 Awaiting requested review from HeshamHM28

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mashraf-222 @mohammedahmed18