Skip to content

[Code-Repair] Disable repair if there was correct candidates (CF-970) #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohammedahmed18 merged 1 commit into from
Jan 6, 2026
+16 −1
Merged

[Code-Repair] Disable repair if there was correct candidates (CF-970) #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions codeflash/code_utils/config_consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
TOTAL_LOOPING_TIME_LSP = 10.0 # Kept same timing for LSP mode to avoid in increase in performance reporting
N_CANDIDATES_LP_LSP = 3

# setting this value to 1 will disable repair if there is at least one correct candidate
MIN_CORRECT_CANDIDATES = 2

# Code repair
REPAIR_UNMATCHED_PERCENTAGE_LIMIT = 0.4 # if the percentage of unmatched tests is greater than this, we won't fix it (lowering this value makes the repair more stricted)
MAX_REPAIRS_PER_TRACE = 4 # maximum number of repairs we will do for each function
Expand Down
14 changes: 13 additions & 1 deletion codeflash/optimization/function_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
INDIVIDUAL_TESTCASE_TIMEOUT,
MAX_ADAPTIVE_OPTIMIZATIONS_PER_TRACE,
MAX_REPAIRS_PER_TRACE,
MIN_CORRECT_CANDIDATES,
N_TESTS_TO_GENERATE_EFFECTIVE,
REFINE_ALL_THRESHOLD,
REFINED_CANDIDATE_RANKING_WEIGHTS,
Expand Down Expand Up @@ -887,6 +888,7 @@ def process_single_candidate(
baseline_results=original_code_baseline,
original_helper_code=original_helper_code,
file_path_to_helper_classes=file_path_to_helper_classes,
eval_ctx=eval_ctx,
code_context=code_context,
candidate=candidate,
exp_type=exp_type,
Expand Down Expand Up @@ -2045,13 +2047,20 @@ def repair_if_possible(
self,
candidate: OptimizedCandidate,
diffs: list[TestDiff],
eval_ctx: CandidateEvaluationContext,
code_context: CodeOptimizationContext,
test_results_count: int,
exp_type: str,
) -> None:
if self.repair_counter >= MAX_REPAIRS_PER_TRACE:
logger.debug(f"Repair counter reached {MAX_REPAIRS_PER_TRACE}, skipping repair")
return

successful_candidates_count = sum(1 for is_correct in eval_ctx.is_correct.values() if is_correct)
if successful_candidates_count >= MIN_CORRECT_CANDIDATES:
logger.debug(f"{successful_candidates_count} of the candidates were correct, no need to repair")
return

if candidate.source not in (OptimizedCandidateSource.OPTIMIZE, OptimizedCandidateSource.OPTIMIZE_LP):
# only repair the first pass of the candidates for now
logger.debug(f"Candidate is a result of {candidate.source.value}, skipping repair")
Expand Down Expand Up @@ -2089,6 +2098,7 @@ def run_optimized_candidate(
baseline_results: OriginalCodeBaseline,
original_helper_code: dict[Path, str],
file_path_to_helper_classes: dict[Path, set[str]],
eval_ctx: CandidateEvaluationContext,
code_context: CodeOptimizationContext,
candidate: OptimizedCandidate,
exp_type: str,
Expand Down Expand Up @@ -2144,7 +2154,9 @@ def run_optimized_candidate(
logger.info("h3|Test results matched ✅")
console.rule()
else:
self.repair_if_possible(candidate, diffs, code_context, len(candidate_behavior_results), exp_type)
self.repair_if_possible(
candidate, diffs, eval_ctx, code_context, len(candidate_behavior_results), exp_type
)
return self.get_results_not_matched_error()

logger.info(f"loading|Running performance tests for candidate {optimization_candidate_index}...")
Expand Down
Loading