Function optimizer refactor #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_passes Test perf only after behavior passes
…x' into function-optimizer-refactor
Closed
|
added E2E testing for my bug fix here If you don't mind, one thing you should look into, is that when whenever we CTRL+C, on main it properly cleans up test file paths, with these changes, no cleanup is done, we don't want to leave around test files due to a crash. |
|
still having issues when running on codebases, even though e2e tests pass. will check further |
misrasaurabh1
approved these changes
Feb 19, 2025
KRRT7
reviewed
Feb 19, 2025
Comment on lines
+181
to
+190
| for test_file in function_optimizer.test_files.get_by_type(TestType.GENERATED_REGRESSION).test_files: | ||
| test_file.instrumented_behavior_file_path.unlink(missing_ok=True) | ||
| test_file.benchmarking_file_path.unlink(missing_ok=True) | ||
| for test_file in function_optimizer.test_files.get_by_type(TestType.EXISTING_UNIT_TEST).test_files: | ||
| test_file.instrumented_behavior_file_path.unlink(missing_ok=True) | ||
| test_file.benchmarking_file_path.unlink(missing_ok=True) | ||
| for test_file in function_optimizer.test_files.get_by_type(TestType.CONCOLIC_COVERAGE_TEST).test_files: | ||
| test_file.instrumented_behavior_file_path.unlink(missing_ok=True) | ||
| if function_optimizer.test_cfg.concolic_test_root_dir: | ||
| shutil.rmtree(function_optimizer.test_cfg.concolic_test_root_dir, ignore_errors=True) |
There was a problem hiding this comment.
nitpick: we have cleanup_paths within codeutils, let's use it for this, thought it has to be updated to handle directories
KRRT7
reviewed
Feb 19, 2025
Comment on lines
+332
to
+346
| for generated_test_path in generated_test_paths: | ||
| generated_test_path.unlink(missing_ok=True) | ||
| for generated_perf_test_path in generated_perf_test_paths: | ||
| generated_perf_test_path.unlink(missing_ok=True) | ||
| for test_paths in instrumented_unittests_created_for_function: | ||
| test_paths.unlink(missing_ok=True) | ||
| for fn in function_to_concolic_tests: | ||
| for test in function_to_concolic_tests[fn]: | ||
| if not test.tests_in_file.test_file.parent.exists(): | ||
| logger.warning( | ||
| f"Concolic test directory {test.tests_in_file.test_file.parent} does not exist so could not be deleted." | ||
| ) | ||
| shutil.rmtree(test.tests_in_file.test_file.parent, ignore_errors=True) | ||
| break # need to delete only one test directory | ||
|
|
# Conflicts: # codeflash/optimization/optimizer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.