Skip to content

⚡️ Speed up function parse_log_pytest_options by 230% #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function parse_log_pytest_options by 230% #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions evaluation/benchmarks/testgeneval/log_parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,34 @@ def parse_log_pytest_options(log: str) -> dict[str, str]:
"""
option_pattern = re.compile(r'(.*?)\[(.*)\]')
test_status_map = {}
test_status_values = {status.value for status in TestStatus}

for line in log.split('\n'):
if any([line.startswith(x.value) for x in TestStatus]):
# Check for valid starting status using a set for O(1) look-up
line_status = line.split()[0] if line else None
if line_status in test_status_values:
# Additional parsing for FAILED status
if line.startswith(TestStatus.FAILED.value):
if line_status == TestStatus.FAILED.value:
line = line.replace(' - ', ' ')
test_case = line.split()
if len(test_case) <= 1:
continue
has_option = option_pattern.search(test_case[1])
if has_option:
main, option = has_option.groups()
# Directly match and extract using regex
match = option_pattern.match(test_case[1])
if match:
main, option = match.groups()
if (
option.startswith('/')
and not option.startswith('//')
and '*' not in option
):
# Simplified since if it doesn't start with '//' and there's no '*'
option = '/' + option.split('/')[-1]
test_name = f'{main}[{option}]'
else:
test_name = test_case[1]
test_status_map[test_name] = test_case[0]

return test_status_map


Expand Down