`angular-ui-bootstrap-bower` should not be a dependency

[domoritz]

I think this is used for the demos but it installs some dependencies that are not needed.

[codef0rmer]

If I do not add it in bower.json then you can not run the demos locally unless you manually resolve angular-ui-bootstrap dependency. Why do you think it's wrong?

[domoritz]

I have an app without bootstrap and my build scripts automatically include all bower dependencies (https://github.com/yeoman/generator-angular). This means that bootstrap UI is loaded into my app although it is not needed which breaks some components in the UI. I had to manually delete angular-ui-bootstrap from the package.json which will of course break if somebody else downloads the code for my app and installs the bower components.

[mtraynham]

Broke my build as well, because that particular dependency caused conflicts with the angular version. It uses angular < 1.3 instead of the 1.3.X series. Make it a dev dependency?

[codef0rmer]

@domoritz and @mtraynham guys, let me know if it works for you.

[mtraynham]

I would have left the other dependencies in the dependencies section as they are requirements for this library. The angular-ui-bootstrap-bower dependency is only for this repo and demo purposes, thus it shouldn't be a requirement for an end-user to install. Also, there is a more supported version of angular-ui-bootstrap-bower which is just angular-ui-bootstrap.

[codef0rmer]

The bower install angular-dragdrop command unnecessarily installs other dependencies in your project under bower_components/, now it will not because of devDependencies. And nobody needs angular-dragdrop's dependencies in production.

[mtraynham]

Not sure I follow. Say I have an empty project and I want my first dependency to be angular-dragdrop. So, I type bower install angular-dragdrop. If I was an ignorant user or used wiredep, this would only attach angular-dragdrop to the index page. angular nor jquery wouldn't be downloaded or attached because you didn't specify them as dependencies.

The angular-ui-bootstrap-bower is not a dependency for the end user, it is only a dev-dependency to showcase a running demo. Follow?

It is important for you to specify dependencies though as I may use angular 1.1.X and this library only supports 1.3.X (just an example).

As of that last change, I now have to include jquery-ui in my own bower.

[domoritz]

Fully agree with @mtraynham. The only problem for my deployment was bootstrap. Without jquery and jqueryui as a dependency, dragdrop doesn't work.

[codef0rmer]

Makes sense!