Skip to content

Conversation

@ct-vrushti
Copy link
Contributor

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@ct-dixit ct-dixit merged commit e25c7a8 into dev-v4.0.0 Jul 4, 2025
@ct-dixit ct-dixit deleted the 18018-fix-issues branch July 4, 2025 06:29
ct-dixit added a commit that referenced this pull request Jul 4, 2025
* free version update (#29)

Co-authored-by: ct-vrushti <vrushti.pcoded@gmail.com>

* fix issues (#31)

* fix css related issues

* fix issue and pr review done

* base path set

* version update

---------

Co-authored-by: ct-vrushti <vrushti.pcoded@gmail.com>
Co-authored-by: DIKSHIT MORADIYA <dixit.moradia@phoenixcoded.co>

* add CICD

---------

Co-authored-by: ct-vrushti <vrushti.chopda@codedthemes.com>
Co-authored-by: ct-vrushti <vrushti.pcoded@gmail.com>
@ct-dixit ct-dixit mentioned this pull request Jul 4, 2025
12 tasks
ct-dixit added a commit that referenced this pull request Jul 4, 2025
* free version update (#29)



* fix issues (#31)

* fix css related issues

* fix issue and pr review done

* base path set

* version update

---------




* add CICD

---------

Co-authored-by: ct-vrushti <vrushti.chopda@codedthemes.com>
Co-authored-by: ct-vrushti <vrushti.pcoded@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants