Include path in HTTP source repository type URI #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows HTTP source repository type URL in the form of
"https://example.com/updates/subfolder"
. Before the fix the update URL would become (e.g. for app-v1.2.3.zip)"https://example.com/app-v1.2.3.zip"
when it should be"https://example.com/updates/subfolder/app-v1.2.3.zip"
.In case of a URL without a path, an empty string is returned:
URL:
https://example.com/updates/v2
Scheme:
string(5) "https"
Host:
string(11) "example.com"
Path:
string(11) "/updates/v2"
baseUrl:
https://example.com/updates/v2
URL:
https://example.com
Scheme:
string(5) "https"
Host:
string(11) "example.com"
Path:
string(0) ""
baseUrl:
https://example.com