fix: DispatchWorker missing a 2-element stop clause in handle_info #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the #203 (comment), the
{:stop, reason}
clause is missing, which leads toCaseClauseError
s instead of proper error handling.I also moved the
handle_info
callback belowhandle_push
as it mentions "all other messages", which logically should be a follow-up to what handle_push` has in its doc.As a side note, I couldn't find a case in which
{:stop, reason, new_state}
forhandle_info
is invoked, but I didn't want to accidentally break anything, so I left it as it was :)