Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DispatchWorker missing a 2-element stop clause in handle_info #261

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

mdlkxzmcp
Copy link
Contributor

As pointed out in the #203 (comment), the {:stop, reason} clause is missing, which leads to CaseClauseErrors instead of proper error handling.

I also moved the handle_info callback below handle_push as it mentions "all other messages", which logically should be a follow-up to what handle_push` has in its doc.

As a side note, I couldn't find a case in which {:stop, reason, new_state} for handle_info is invoked, but I didn't want to accidentally break anything, so I left it as it was :)

@hpopp
Copy link
Member

hpopp commented Aug 30, 2024

Thanks for this!

@hpopp hpopp merged commit 1f6fbeb into codedge-llc:master Aug 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants