Update parameter quoting in Streams extension #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
internal/test_helpers/fixtures/streams/passandinternal/test_helpers/fixtures/transactions/passfiles to correct the syntax of Redis CLI commands and updates to logging format in theinternal/test_streams_xadd.goandinternal/test_streams_xrange.gofiles.Syntax Corrections for Redis CLI Commands:
internal/test_helpers/fixtures/streams/pass: Modified Redis CLI commands to remove quotes around stream names and IDs. [1] [2] [3] [4] [5] [6] [7] [8]internal/test_helpers/fixtures/transactions/pass: Modified Redis CLI commands to remove quotes around stream names and IDs. [1] [2] [3] [4] [5] [6] [7] [8]Logging Format Updates:
internal/test_streams_xadd.go: Updated logging format to remove unnecessary quotes around variables in log messages. [1] [2]internal/test_streams_xrange.go: Updated logging format to remove unnecessary quotes around variables in log messages.Import Order Fixes:
internal/test_streams_xrange.go: Fixed the order of import statements.internal/test_streams_xrange_max_id.go: Fixed the order of import statements.