Embed the Yash CC Lobbyside widget - #3875
Open
TropicolX wants to merge 1 commit into
Open
Conversation
Lets an internal host take live 1:1 calls with users on app.codecrafters.io. The widget id must be listed here to load at all — the Lobbyside dashboard alone doesn't put it on the page. Co-authored-by: Cursor <cursoragent@cursor.com>
Bundle ReportChanges will decrease total bundle size by 1.55kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're reinstating Lobbyside for internal use so a host (Yash) can take live 1:1 calls with users on app.codecrafters.io. A new "Yash CC Widget" was created on the Lobbyside dashboard — but a widget id does nothing until it's listed here. This template is what actually loads the script on the page; the dashboard isn't.
What
One
<LobbysideWidget>tag for19427cb6-dd26-40df-9d50-cd8cf57a30a5, audienceeveryone(the point is talking to users, not staff).Also dropped a stale "two" from the block comment above — there were already four public widgets before this change, five now.
Paired change
Presence (the live-visitor roster the host calls from) is allowlisted per widget on the Lobbyside side, so this id also had to be added there: codecrafters-io/lobbyside#554. Order doesn't matter for correctness — until both ship, the widget simply renders nothing.
Test plan
npx ember-template-lint app/templates/application.hbs— cleanapplication.hbs(thelobbyside-widgetunit + integration tests render the component directly with their own ids), so no test updates were neededconfig.x.isStaging) and skipped intestenv — so no test/staging impact expected