-
Notifications
You must be signed in to change notification settings - Fork 26
Add Clojure #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Clojure #136
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@andy1li There's a few differences from the http-server here, but I'd love to hear what y'all think about them. Here's a link to the Babashka github Github. It's pretty well established in the Clojure community. |
This version of the Clojure starter is a little different. Because this isn't intended as a long running process, it makes more sense to avoid JVM Clojure and use Babashka, which has a faster startup time.
I think there's a few challenges that are going to benefit from this alternate configuration.
It installs Babashka with a
.codecrafters/install.sh
script that gets called in the dockerfile. I'm not sure if there's a convention for using tools without an explicit Dockerfile base, but this seems pretty inline with how other languages work.This is kindof a nitpicky thing, but it's a Clojure convention to store things in
/resources
and not at the root level, so they're more easily addressed on the classpath. It's not a huge deal, since this working, but if it's possible to modifydownload_sample_databases.sh
and a couple other files on a per-project basis, that'd be great.