-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 1 1
Lines 359 359
=======================================
Hits 325 325
Misses 34 34 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your approach is wrong.
See previous changes and discussion in #109.
Suggestion with the correct code has been provided.
@@ -12,7 +12,7 @@ Gem::Specification.new do |s| | |||
s.homepage = 'https://github.com/codecov/codecov-ruby' | |||
s.license = 'MIT' | |||
s.platform = Gem::Platform::RUBY | |||
s.required_ruby_version = '~> 2.4' | |||
s.required_ruby_version = '>= 2.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.required_ruby_version = '>= 2.4' | |
s.required_ruby_version = '>= 2.4', '< 4' |
So Rails is wrong too? https://github.com/rails/rails/blob/master/activerecord/activerecord.gemspec#L12 |
I think, yes. Do you assume it can't be? Ha-ha. Rails has many errors (see issues), some of them potential (not noticed or not important for now). It's OK, but we can do it better. Rails is not a standard for Ruby (especially out of web). If you can argue with something except "some gem has this too", but with something truly about Ruby and the subject — please, do. |
See the 2019 ruby conf and matz presentation about backward compatibilty. It should br sufficient. |
OK, I've checked it. I saw this: https://youtu.be/2g9R7PUCEXo?t=1004
So, there were plans for Ruby 2.7 but unknown changes for Ruby 3.0. Because it's unknown feature, and even some changes become reverted before releases. |
Fix #121