This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Updated appveyor enabled values detection #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 90.52% 90.55% +0.02%
==========================================
Files 1 1
Lines 359 360 +1
==========================================
+ Hits 325 326 +1
Misses 34 34
Continue to review full report at Codecov.
|
|
Workaround: |
Comment on lines
+50
to
+51
| ci = if (ENV['CI'] == 'True' && ENV['APPVEYOR'] == 'True') || | ||
| (ENV['CI'] == 'true' && ENV['APPVEYOR'] == 'true') |
There was a problem hiding this comment.
Can we just do ENV['CI'].downcase and ENV['APPVEYOR'].downcase?
| assert_equal('build', result['params'][:build]) | ||
| assert_equal('owner/repo/job', result['params'][:job]) | ||
| assert_equal('f881216b-b5c0-4eb1-8f21-b51887d1d506', result['params']['token']) | ||
| %w[True true].each do |enabled_value| |
There was a problem hiding this comment.
I'd rather this be two different tests
|
Closing due to deprecation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, please update with the recent changes of appveyor environment.